Fix/ordering filter mixed str datetime#11679
Open
rautaditya2606 wants to merge 2 commits into
Open
Conversation
|
@rautaditya2606 is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
8b3fe81 to
057b2ca
Compare
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
7393f5d to
86558f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #11678
Proposed Changes
_prepare_ordering_comparison()to only call_parse_date()on operands that are actually strings._ensure_both_dates_naive_or_aware()when both operands resolve todatetime.>,>=,<,<=operators intry/except TypeError→FilterErrorto preserve existing error behavior.How did you test it?
92 tests passed.
Notes for the reviewer
_prepare_ordering_comparison()called_parse_date()on both operands when either was a string, crashing when the other was already adatetime.datetimecomparisons are valid — ISO date strings inDocument.metacompared againstdatetimefilter values is a real use case.TypeErrorwrapping keeps error behavior consistent with existing Haystack conventions.Checklist