Skip to content

fix(autotp): when using autotp, ignore the consistency of certain data within the tp_group.#8125

Open
1787648106 wants to merge 6 commits into
deepspeedai:masterfrom
1787648106:ignore_check_cache_while_autotp
Open

fix(autotp): when using autotp, ignore the consistency of certain data within the tp_group.#8125
1787648106 wants to merge 6 commits into
deepspeedai:masterfrom
1787648106:ignore_check_cache_while_autotp

Conversation

@1787648106

Copy link
Copy Markdown

When using autotp, the consistency check for the KV cache within the TP group is bypassed. Recent popular methods, such as on-policy distillation, require the model to generate output during training, which would otherwise cause the data consistency check to fail.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a865dd365c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread deepspeed/runtime/utils.py Outdated
@delock

delock commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

@1787648106 thanks for your fix. I agree with codex that the import from transformers should be catched. If there is import error, then the tensor won't be HF model KV cache. This would avoid break existing use cases.

Also can you sign-off your commits to pass DCO check? Thanks!

@1787648106

Copy link
Copy Markdown
Author

@1787648106 thanks for your fix. I agree with codex that the import from transformers should be catched. If there is import error, then the tensor won't be HF model KV cache. This would avoid break existing use cases.

Also can you sign-off your commits to pass DCO check? Thanks!

Done, thank you!

1021501010 and others added 3 commits July 9, 2026 20:29
…tp_group

Signed-off-by: lunzhongwang <1787648106@qq.com>
Signed-off-by: lunzhongwang <1787648106@qq.com>
Signed-off-by: lunzhongwang <1787648106@qq.com>
@1787648106 1787648106 force-pushed the ignore_check_cache_while_autotp branch from 4d08564 to fbfe8fd Compare July 9, 2026 12:29
@delock

delock commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Hi @1787648106 can you fix the formatting errors? You may want to refer to this link for essential pre CI checks. Thanks!
https://github.com/deepspeedai/DeepSpeed/blob/master/AGENTS.md#commit--ci-requirements

Signed-off-by: lunzhongwang <1787648106@qq.com>
@1787648106

1787648106 commented Jul 10, 2026

Copy link
Copy Markdown
Author

Hi @1787648106 can you fix the formatting errors? You may want to refer to this link for essential pre CI checks. Thanks! https://github.com/deepspeedai/DeepSpeed/blob/master/AGENTS.md#commit--ci-requirements

done

@tohtana tohtana added this pull request to the merge queue Jul 10, 2026
@tohtana tohtana removed this pull request from the merge queue due to a manual request Jul 10, 2026
@delock delock added this pull request to the merge queue Jul 11, 2026
@delock delock removed this pull request from the merge queue due to a manual request Jul 11, 2026
@delock delock added this pull request to the merge queue Jul 11, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants