storage_pool V2: support flexible num_data_slices for Gen2 pools - #55
Open
Prasant-Dell wants to merge 1 commit into
Open
storage_pool V2: support flexible num_data_slices for Gen2 pools#55Prasant-Dell wants to merge 1 commit into
Prasant-Dell wants to merge 1 commit into
Conversation
Replace the hardcoded TwoPlusTwo=2 / EightPlusTwo=8 data-slice mapping in StoragePool.create() with verbatim pass-through of numDataSlices and numProtectionSlices, falling back to the protection_scheme presets when no explicit slice count is given. check_create_params() now validates numDataSlices as a positive integer and requires one of numDataSlices or protectionScheme. Backward compatible with existing protection_scheme usage. Tests: tests/gen2/test_storage_pool.py (U-001..U-007). FEAT-23070
Prasant-Dell
requested review from
Krunal-Thakkar,
MangirishK,
Saksham-Nautiyal and
rounak-adhikary
June 2, 2026 13:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded TwoPlusTwo=2 / EightPlusTwo=8 data-slice mapping in StoragePool.create() with verbatim pass-through of numDataSlices and numProtectionSlices, falling back to the protection_scheme presets when no explicit slice count is given. check_create_params() now validates numDataSlices as a positive integer and requires one of numDataSlices or protectionScheme. Backward compatible with existing protection_scheme usage.
Tests: tests/gen2/test_storage_pool.py (U-001..U-007).
FEAT-23070