fix(ext/node): handle errors when piping object mode to non-object mode streams#32742
Open
bartlomieju wants to merge 1 commit intomainfrom
Open
fix(ext/node): handle errors when piping object mode to non-object mode streams#32742bartlomieju wants to merge 1 commit intomainfrom
bartlomieju wants to merge 1 commit intomainfrom
Conversation
…de streams Catch synchronous throws in stream _write/_writev/_transform so errors are properly emitted instead of becoming uncaught exceptions. This fixes piping from object mode readable streams to non-object mode writable streams. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERR_INVALID_ARG_TYPEbeing thrown instead of emitted when piping objects from an object mode stream to a non-object mode stream_write/_writev/_transformcalls in try-catch so user throws are caught and routed through the error handling pathtest-stream-pipe-objectmode-to-non-objectmode.jscompat testTest plan
./x test-compat test-stream-pipe-objectmode-to-non-objectmode.jspasses🤖 Generated with Claude Code