Skip to content

Add support for PerlNavigator#5028

Merged
hsanson merged 4 commits intodense-analysis:masterfrom
rymdbar:topic/perlnavigator
Apr 10, 2026
Merged

Add support for PerlNavigator#5028
hsanson merged 4 commits intodense-analysis:masterfrom
rymdbar:topic/perlnavigator

Conversation

@rymdbar
Copy link
Copy Markdown
Contributor

@rymdbar rymdbar commented Aug 14, 2025

Why settle with one perl language server when ale can have two‽

Fixes #4842.

In my mind this one was ready for merge. First when I was about to finalize the PR creation I realized I'm still running my patched PerlNavigator. Upstreaming should hopefully be fixed with bscan/PerlNavigator#171 so publishing this as a draft.

@rymdbar rymdbar force-pushed the topic/perlnavigator branch 2 times, most recently from a6d0ac0 to 51d2958 Compare August 14, 2025 21:27
@rymdbar
Copy link
Copy Markdown
Contributor Author

rymdbar commented Aug 15, 2025

PerlNavigator v0.8.20 can be used unpatched with ALE + this PR. Marking it as ready for review.

@rymdbar rymdbar marked this pull request as ready for review August 15, 2025 07:31
w0rp
w0rp previously requested changes Aug 15, 2025
Comment thread doc/ale-perl.txt Outdated
@rymdbar rymdbar force-pushed the topic/perlnavigator branch from 51d2958 to 32a2c94 Compare August 15, 2025 12:30
@rymdbar rymdbar marked this pull request as draft August 31, 2025 10:21
@rymdbar
Copy link
Copy Markdown
Contributor Author

rymdbar commented Aug 31, 2025

The newly pushed #5038 conflicts with this one. Thus marking as draft until the other one is merged, since msgh doesn't handle stacked pull-requests.

@rymdbar rymdbar force-pushed the topic/perlnavigator branch from 32a2c94 to 1c97daa Compare October 28, 2025 15:08
@rymdbar rymdbar marked this pull request as ready for review October 28, 2025 15:08
@rymdbar rymdbar requested a review from w0rp October 28, 2025 16:57
@hsanson hsanson closed this Nov 22, 2025
@hsanson hsanson reopened this Nov 22, 2025
@rymdbar rymdbar force-pushed the topic/perlnavigator branch from 890a730 to a081cb6 Compare November 22, 2025 14:06
Copy link
Copy Markdown
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for completing the contribution.

@hsanson hsanson dismissed w0rp’s stale review April 10, 2026 14:19

Already addressed.

@hsanson hsanson merged commit b1b027d into dense-analysis:master Apr 10, 2026
7 checks passed
hsanson added a commit to hsanson/ale that referenced this pull request Apr 18, 2026
* upstream/master:
  feat(markdown): add rumdl server and fixer (dense-analysis#5115)
  fix(terraform-ls): return current buffer dir when missing .terraform (dense-analysis#5103)
  fix expert lsp stdio and register capability (dense-analysis#5113)
  Add support for PerlNavigator (dense-analysis#5028)
  Use ale#Pad for option padding across the codebase (dense-analysis#5118)
  Add support for LilyPond syntax (dense-analysis#5117)
  feat: Load Prettier from cjs also
  fix(tests): fix ale_c_build_dir_names being unset in tests (dense-analysis#5109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

About adding support for PerlNavigator

3 participants