Support cache expression filter pushdown JOIN#30
Draft
peterxcli wants to merge 10 commits into
Draft
Conversation
…ct metadata, and implement TPC-H benchmark script for query condition cache performance evaluation.
…on injection and improve filter propagation logic. Removed unused post-optimization function and adjusted cache filter checks in `CheckStatistics` for better performance and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly refactors and improves the query condition cache optimizer and filter logic. The main changes focus on making cache filter injection more robust and flexible, improving performance, and enhancing debuggability. The optimizer now more accurately associates cache filters with table scans, supports better statistics-based pruning, and provides improved utilities for cache key handling and introspection.
Key changes include:
Query Condition Cache Optimizer Refactor:
LogicalGetnodes, then associating and injecting cache filters based on filter expressions and table bindings. This allows for more robust and accurate cache filter injection. [1] [2]InjectCacheExpressionmethod, which ensures theROW_IDcolumn is present and attaches the filter directly to the correct scan node. [1] [2] [3]Cache Filter and Key Enhancements:
CacheExpressionFilterto store and display its associatedCacheKey, and added aToStringmethod for easier debugging and introspection. [1] [2]Performance Improvements:
Test Adjustments:
CacheExpressionFilterwith the newCacheKeyparameter.These changes collectively make the query condition cache system more robust, maintainable, and performant.