Skip to content

Fix Java trust store setup for Java ecosystems#632

Open
thavaahariharangit wants to merge 1 commit into
mainfrom
fix/java-cacerts-for-gradle
Open

Fix Java trust store setup for Java ecosystems#632
thavaahariharangit wants to merge 1 commit into
mainfrom
fix/java-cacerts-for-gradle

Conversation

@thavaahariharangit

Copy link
Copy Markdown
Contributor

Summary

  • fail fast if update-ca-certificates does not succeed in the updater container
  • import the proxy CA into Java cacerts for Java-based ecosystems (gradle, maven, sbt)
  • add unit tests for Java ecosystem detection helper

Why

Gradle/JVM-based dependency resolution can rely on Java trust stores. Updating system certificates alone may not be sufficient in updater images. Importing the CLI proxy CA into Java cacerts ensures TLS trust for Maven/Gradle plugin repositories when routed through the proxy.

Validation

  • go test ./internal/infra/...

@thavaahariharangit thavaahariharangit requested review from a team as code owners June 19, 2026 15:24
Comment thread internal/infra/run.go
return fmt.Errorf("failed to update CA certificates in updater container")
}

if isJavaBasedPackageManager(params.Job.PackageManager) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to avoid ecosystem logic bleeding out of the images and into the runners (CLI/Action). Is there a way to achieve this purely in dependabot-core? Perhaps a ca-certificates-java JKS hook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants