feat: add ssoId support to loadSettings and add loadAllSettings for multi-SSO tenants#333
Merged
Merged
Conversation
…ulti-SSO tenants Adds parity with the Node.js and Go SDKs: - loadSettings(tenantId, ssoId): optional ssoId param to fetch a specific SSO config - loadAllSettings(tenantId): new method returning all SSO configs for a tenant via /v2/mgmt/sso/settings/all The existing loadSettings(tenantId) overload is preserved for backward compatibility and now delegates to the two-argument form with ssoId=null. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🐕 Review complete — View session on Shuni Portal 🐾 |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Adds loadSettings(tenantId, ssoId) and loadAllSettings(tenantId) to the SSO management service, closing the parity gap with the Go/Node SDKs. Query params, the /all route, and the SSOSettings JSON property all match the Go SDK exactly, and the original loadSettings(tenantId) stays backward-compatible.
Sniffed out 1 issue:
- 1 🟠 HIGH: import out of alphabetical order will fail the checkstyle build
See inline comment for details. Otherwise — good bones! Woof!
Member
Author
|
@slavikm this is for Mark43 - mind reviewing? |
slavikm
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadSettings(tenantId, ssoId)— adds an optionalssoIdparameter toloadSettings. WhenssoIdis non-blank it is forwarded as a query parameter to the existingGET /v2/mgmt/sso/settingsendpoint, allowing callers to retrieve a specific SSO configuration. When blank/null, behavior is identical to the original method.loadSettings(tenantId)— preserved unchanged for backward compatibility; now delegates to the two-argument overload withssoId=null.loadAllSettings(tenantId)— new method that callsGET /v2/mgmt/sso/settings/alland returns anSSOAllSettingsResponsecontaining aList<SSOTenantSettingsResponse>, filling the parity gap with the Node.js and Go SDKs.This closes the parity gap with
descope/node-sdk(loadSettings(tenantId, ssoId?)andloadAllSettings(tenantId)) and the equivalent Go SDK methods.Test plan
loadSettings(tenantId, ssoId)— empty tenantId error, success with ssoId, success with null ssoIdloadAllSettings(tenantId)— empty tenantId error, success case🤖 Generated with Claude Code