chore(webapp): migration to vuetify 3#1173
Conversation
a7bb28b to
519ec06
Compare
AI-assisted changes.
I played with everything I could think of on the website:
direct debit donation
account creation, login, 2fa enabled, change email, delete account
domain list, filtering
rrset creation and deletion
scrolled through all pages of the web site
519ec06 to
f5434b3
Compare
vasimi
left a comment
There was a problem hiding this comment.
Just passing by. 🫣 Seems like this PR is actually fixing the bug that made me come to this repo (record value validation being too eager), but there's a bunch of visual issues that probably don't make sense to report, it'd be easier to just fix them.
If you'd be interested, I can go through the whole app and try preparing a patch once I have some free time.
| <v-btn class="mx-4 mr-0" color="primary" variant="flat" :to="{name: 'login'}" v-if="!authenticated">Log In</v-btn> | ||
| <v-btn class="mx-4 mr-0" color="primary" variant="outlined" @click="logout" v-if="authenticated">Log Out</v-btn> |
There was a problem hiding this comment.
The <v-app-bar /> content class no longer has padding, so the login button is right on the edge of the viewport. Also, the spacing between the two buttons seems too big, so just zeroing out ml instead of mr could work?
| <v-btn class="mx-4 mr-0" color="primary" variant="flat" :to="{name: 'login'}" v-if="!authenticated">Log In</v-btn> | |
| <v-btn class="mx-4 mr-0" color="primary" variant="outlined" @click="logout" v-if="authenticated">Log Out</v-btn> | |
| <v-btn class="mx-4 ml-0" color="primary" variant="flat" :to="{name: 'login'}" v-if="!authenticated">Log In</v-btn> | |
| <v-btn class="mx-4 ml-0" color="primary" variant="outlined" @click="logout" v-if="authenticated">Log Out</v-btn> |
| src="./assets/logo.svg" | ||
| alt="deSEC Logo" | ||
| class="app-logo" | ||
| height="32" |
| :hide-details="!('mnemonics' in field) && (!content.length || !($v.fields.$each[index].$invalid || $v.fields[index].$invalid))" | ||
| :error="$v.fields.$each[index].$invalid || $v.fields[index].$invalid" | ||
| :hide-details="!('mnemonics' in field) && !fieldInvalid(index)" | ||
| :error="fieldInvalid(index)" |
There was a problem hiding this comment.
| <v-btn | ||
| v-bind="attrs" | ||
| v-on="on" | ||
| v-bind="props" |
That would be very welcome! Thank you <3 |




AI-assisted changes.
I played with everything I could think of on the website: