Skip to content

chore(webapp): migration to vuetify 3#1173

Open
nils-wisiol wants to merge 1 commit into
mainfrom
20260109_vuetify3
Open

chore(webapp): migration to vuetify 3#1173
nils-wisiol wants to merge 1 commit into
mainfrom
20260109_vuetify3

Conversation

@nils-wisiol
Copy link
Copy Markdown
Contributor

AI-assisted changes.

I played with everything I could think of on the website:

  • direct debit donation
  • account creation, login, 2fa enabled, change email, delete account
  • domain list, filtering
  • rrset creation and deletion
  • scrolled through all pages of the web site

AI-assisted changes.

I played with everything I could think of on the website:

    direct debit donation
    account creation, login, 2fa enabled, change email, delete account
    domain list, filtering
    rrset creation and deletion
    scrolled through all pages of the web site
Copy link
Copy Markdown

@vasimi vasimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just passing by. 🫣 Seems like this PR is actually fixing the bug that made me come to this repo (record value validation being too eager), but there's a bunch of visual issues that probably don't make sense to report, it'd be easier to just fix them.

If you'd be interested, I can go through the whole app and try preparing a patch once I have some free time.

Comment thread www/webapp/src/App.vue
Comment on lines +49 to +50
<v-btn class="mx-4 mr-0" color="primary" variant="flat" :to="{name: 'login'}" v-if="!authenticated">Log In</v-btn>
<v-btn class="mx-4 mr-0" color="primary" variant="outlined" @click="logout" v-if="authenticated">Log Out</v-btn>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <v-app-bar /> content class no longer has padding, so the login button is right on the edge of the viewport. Also, the spacing between the two buttons seems too big, so just zeroing out ml instead of mr could work?

Suggested change
<v-btn class="mx-4 mr-0" color="primary" variant="flat" :to="{name: 'login'}" v-if="!authenticated">Log In</v-btn>
<v-btn class="mx-4 mr-0" color="primary" variant="outlined" @click="logout" v-if="authenticated">Log Out</v-btn>
<v-btn class="mx-4 ml-0" color="primary" variant="flat" :to="{name: 'login'}" v-if="!authenticated">Log In</v-btn>
<v-btn class="mx-4 ml-0" color="primary" variant="outlined" @click="logout" v-if="authenticated">Log Out</v-btn>
Image

Comment thread www/webapp/src/App.vue
src="./assets/logo.svg"
alt="deSEC Logo"
class="app-logo"
height="32"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
height="32"
height="32"
width="147"

the img element is too wide and is offset towards the center of the app bar as a result, vuetify is doing some responsive magic and it's not doing it well; setting width seems to fix it

Image

:hide-details="!('mnemonics' in field) && (!content.length || !($v.fields.$each[index].$invalid || $v.fields[index].$invalid))"
:error="$v.fields.$each[index].$invalid || $v.fields[index].$invalid"
:hide-details="!('mnemonics' in field) && !fieldInvalid(index)"
:error="fieldInvalid(index)"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob caused by vuetify update, the default text-field style now has a background and it looks weird without spacing on top (but adding spacing would make the rows too big?)

Suggested change
:error="fieldInvalid(index)"
variant="underlined"
:error="fieldInvalid(index)"
Image

<v-btn
v-bind="attrs"
v-on="on"
v-bind="props"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<v-btn /> now defaults to a style with background, looks super weird without any spacing between the btns

Suggested change
v-bind="props"
v-bind="props"
variant="text"
Image

@peterthomassen
Copy link
Copy Markdown
Member

If you'd be interested, I can go through the whole app and try preparing a patch once I have some free time.

That would be very welcome! Thank you <3

@eyJhb
Copy link
Copy Markdown

eyJhb commented May 18, 2026

image

the advanced in tokens will show errors even when fields are filled out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants