Skip to content

Fix Terraform Sentinel prerelease version resolution in scenario tests#1648

Open
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-failing-github-actions-job
Open

Fix Terraform Sentinel prerelease version resolution in scenario tests#1648
Copilot wants to merge 4 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Bug Fix

The test-scenarios (terraform) job was failing while installing Sentinel in Terraform scenarios. The installer was corrupting Sentinel prerelease version strings, producing invalid download URLs for the latest release.

  • What was the bug?

    find_sentinel_version_from_url() used tr -d ${prefix} to strip the sentinel_ prefix from release names. tr -d deletes matching characters anywhere in the string, so sentinel_0.40.1-beta2 became 0.40.1-ba2, and the feature attempted to fetch non-existent Sentinel artifacts.

  • How did this change address it?

    Replace character deletion with anchored prefix removal so prerelease suffixes remain intact when resolving the latest Sentinel version.

    # before
    grep -oP ${regex} | tr -d ${prefix} | sort -rV
    
    # after
    grep -oP ${regex} | sed "s/^${prefix}//" | sort -rV
  • Impact

    • Preserves valid Sentinel prerelease identifiers such as 0.40.1-beta2
    • Restores correct asset lookup for Sentinel downloads
    • Unblocks Terraform scenario runs on images exercising Sentinel installation

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'test-scenarios (terraform)' Fix Terraform Sentinel prerelease version resolution in scenario tests May 13, 2026
Copilot AI requested a review from Kaniska244 May 13, 2026 09:21
Copy link
Copy Markdown
Contributor

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Minor version bump needed.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 13, 2026

@copilot Minor version bump needed.

Addressed in b549499.

Copilot AI requested a review from Kaniska244 May 13, 2026 09:34
Copy link
Copy Markdown
Contributor

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Should be 1.4.3 not 1.5.0

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 13, 2026

@copilot Should be 1.4.3 not 1.5.0

Addressed in ef8d01a.

Copilot AI requested a review from Kaniska244 May 13, 2026 09:44
@Kaniska244 Kaniska244 marked this pull request as ready for review May 13, 2026 09:59
@Kaniska244 Kaniska244 requested a review from a team as a code owner May 13, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants