perf(plugin-git): memoize commit log rows#82
Merged
antfu merged 1 commit intoJul 9, 2026
Conversation
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR improves the performance of the Git plugin’s log panel by memoizing the per-commit row component so that changing the selected commit doesn’t trigger re-renders for every row in the (unvirtualized) commit list.
Changes:
- Wrap
CommitRowwith Reactmemoto avoid unnecessary re-renders. - Keep existing prop shape and selection behavior by continuing to pass the stable
onSelectCommitcallback.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69
Summary
Memoizes the Git dashboard commit row component so selection changes do not re-render every row in the accumulated commit list.
Changes
CommitRowwith Reactmemo.onSelectCommitcallback.Why
LogPanelViewrenders the commit history as an unvirtualized list. WhenselectedHashchanges, only the previously selected and newly selected rows need to update, but the unmemoized row component re-rendered every visible row.Verification
./node_modules/.bin/eslint --fix plugins/git/src/client/components/views/log-panel-view.tsx./node_modules/.bin/tsc -p plugins/git/tsconfig.json --noEmit./node_modules/.bin/vitest run plugins/git/test/git.test.tsgit diff --check