refactor(cloud): remove mitmproxy flags - #102
Merged
Merged
Conversation
Drops the enterprise-only --mitmHost / --mitmPath flags and everything downstream of them: - environment.flags.ts: both flag definitions - cloud.ts: the arg reads and the "--mitmPath requires --mitmHost" check - test-submission.service.ts: TestSubmissionConfig fields, destructuring, and the two configPayload keys - run-cloud-test.ts: the doc comment listing what the MCP tool omits The submitted config payload is unchanged for existing runs: both keys were undefined when the flags were unset, and JSON.stringify drops undefined, so submissions that never passed them stay byte-identical. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the enterprise-only
--mitmHost/--mitmPathflags and everything downstream of them.Changes
src/config/flags/environment.flags.ts— both flag definitions.src/commands/cloud.ts— the two arg reads and the--mitmPath requires --mitmHostvalidation.src/services/test-submission.service.ts— theTestSubmissionConfigfields, their destructuring, and the twoconfigPayloadkeys.src/mcp/tools/run-cloud-test.ts— dropsmitmfrom the doc comment listing what the MCP tool doesn't do.No test or doc referenced these flags; no
mitmstring remains in the repo.Wire compatibility
The submitted
configpayload is unchanged for existing runs: both keys wereundefinedwhen the flags were unset, andJSON.stringifydrops undefined keys — so submissions that never passed the flags produce byte-identical fields.Back-compat note
Citty doesn't reject unknown flags, so an existing invocation passing
--mitmHost=…will now be silently ignored rather than erroring — it keeps running, but stops proxying. If we'd rather it fail loudly, a follow-up can add an explicit "flag removed" error for those two names.Titled
refactor(patch bump) rather than carrying a!: perCLAUDE.md, a breaking marker on 5.x means a real major bump, which seems disproportionate for retiring an enterprise-only flag. Retitle if you want the major.Verification
pnpm typecheck— passes.pnpm lint— 0 errors (32 pre-existing unused-eslint-disable warnings, all in untouched files).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.