chore: regenerate schema types from the current API swagger - #104
Closed
finalerock44 wants to merge 1 commit into
Closed
chore: regenerate schema types from the current API swagger#104finalerock44 wants to merge 1 commit into
finalerock44 wants to merge 1 commit into
Conversation
The generated types were stale by several releases (the compatibility example still showed latestVersion 2.1.0, defaultVersion 1.41.0) - they had not been regenerated since before the 2.5/2.6 additions. Regenerated with openapi-typescript against the swagger carrying Maestro 2.7.0/2.8.0, per the repo rule that this file is never hand-edited. Doc-comment and shape churn only; typecheck, build and the full test suite pass.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to devicecloud-dev/dcd#1220.
src/types/generated/schema.types.tswas stale by several releases — its compatibility example still showedlatestVersion: "2.1.0"/defaultVersion: "1.41.0", so it had not been regenerated since before the 2.5/2.6 additions. Regenerated withopenapi-typescriptagainst the swagger carrying Maestro 2.7.0/2.8.0, per this repo's rule that the file is never hand-edited.The diff is large because of that accumulated staleness, not because of this change. Doc-comment and shape churn only — no runtime behaviour.
pnpm typecheck,pnpm buildand all 194 tests pass.Safe to merge any time after dcd#1220.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.