Skip to content

fix(deps): resolve pnpm audit failures in transitive dependencies - #89

Merged
riglar merged 3 commits into
devfrom
fix/audit-transitive-deps
Jul 23, 2026
Merged

fix(deps): resolve pnpm audit failures in transitive dependencies#89
riglar merged 3 commits into
devfrom
fix/audit-transitive-deps

Conversation

@riglar

@riglar riglar commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

CI's pnpm audit --audit-level moderate gate is failing on every PR (8 vulnerabilities: 4 high, 4 moderate), all in transitive dependencies. This clears the audit:

  • hono 4.12.26 → 4.12.31, fast-uri 3.1.2 → 3.1.4 (under @modelcontextprotocol/sdk) — patched versions fit the parents' semver ranges, so this is a lockfile-only update; no dependency specs changed.
  • brace-expansion (GHSA-3jxr-9vmj-r5cp) — the existing pnpm.overrides, added for a previous brace-expansion advisory, were pinning 1.1.13 / 5.0.6, which are exactly the versions the new advisory flags. Overrides updated to 1.1.16 / 5.0.7 (and the 4.x range widened to >=3.0.0 to match the advisory).
  • @hono/node-server (GHSA-frvp-7c67-39w9) — not fixable by updating: the patch is in 2.0.5 (a major), and the MCP SDK — even at its latest release — pins ^1.19.9. Added a pnpm.auditConfig.ignoreGhsas exemption for this single advisory rather than force-overriding a major into the SDK. The vulnerability is path traversal in serve-static over HTTP on Windows; dcd-mcp is stdio-only and never serves static files, so the vulnerable path is unreachable. Remove the exemption once the SDK adopts @hono/node-server 2.x.

pnpm audit --audit-level moderate now exits 0 (the one remaining moderate is the explicitly ignored GHSA).

Test plan

  • pnpm audit --audit-level moderate exits 0
  • pnpm typecheck, pnpm lint, pnpm build pass locally
  • CI (including the maintainer-run integration suite before merge)

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

riglar and others added 3 commits July 22, 2026 14:06
- bump hono 4.12.26 -> 4.12.31 and fast-uri 3.1.2 -> 3.1.4 (lockfile only)
- update brace-expansion overrides: the pins added for the previous
  advisory (1.1.13 / 5.0.6) are exactly the versions flagged by
  GHSA-3jxr-9vmj-r5cp; now pin 1.1.16 / 5.0.7
- ignore GHSA-frvp-7c67-39w9 (@hono/node-server serve-static path
  traversal on Windows): the fix is a major (2.0.5) outside the MCP
  SDK's ^1.19.9 range, and dcd-mcp is stdio-only and never serves
  static files. Remove the exemption when the SDK adopts 2.x.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…error

Debug commit — will be reverted once the failure cause is captured.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@devicecloud-dev devicecloud-dev deleted a comment from claude Bot Jul 22, 2026
@claude

claude Bot commented Jul 22, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@riglar
riglar merged commit cc5ee4d into dev Jul 23, 2026
8 of 9 checks passed
@riglar
riglar deleted the fix/audit-transitive-deps branch July 23, 2026 13:20
@finalerock44 finalerock44 mentioned this pull request Aug 6, 2026
14 tasks
finalerock44 added a commit that referenced this pull request Aug 7, 2026
Promote from dev to stable:

* feat: client-side envelope encryption of app binaries, flow zips and env vars
  (#94, #101) — opt-in via `--encrypt` / `DCD_ENCRYPT_BINARIES=1` and off by
  default, so uploads stay byte-identical unless asked for. Per-upload DEK,
  chunked AES-256-GCM container, X25519 sealed-box DEK wrap; encrypted binaries
  dedup on the plaintext hash so re-uploads still hit the cache.
* feat(artifacts): prefer server-assembled bundle delivery for downloads (#93) —
  falls back to the inline endpoint on 501, so it degrades cleanly against an
  API that has not shipped bundles.
* feat(device): add Android API level 37 (Android 17) (#107) — the flag enum
  accepts 37, but the device/API-level pair is validated against the
  compatibility matrix the *target* API serves, and production still tops out at
  36, so 37 is refused client-side until the platform gate flips.
* refactor(cloud): remove the enterprise-only --mitmHost / --mitmPath flags
  (#102). The submitted config payload for runs that never passed them is
  byte-identical.
* fix(deps) / deps: clear every outstanding pnpm audit advisory (#89, #92, #95,
  #100, #106), bump chalk 5 -> 6, and regenerate the schema types from the
  current API swagger (#105).

No platform prerequisite this time: the envelope decrypt half (dcd api +
simulators) is already on production with both env KEK public keys pinned,
bundle delivery has a 501 fallback, and API 37 is gated server-side.

Carries only the source delta — package.json version, CHANGELOG.md and the
release-please manifests stay as release-please left them on production.

Release-As: 5.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant