feat(config): add optional agentic /fix feature for automated PR creation - #436
feat(config): add optional agentic /fix feature for automated PR creation#436matheusandre1 wants to merge 1 commit into
Conversation
🤖 ThrillhouseBot PR SummaryWhat this PR doesAdds an opt-in /fix command that drafts a fix across the relevant files, commits it to a bot-owned branch, and opens a clearly attributed PR targeting the reviewed PR's branch. Control-Flow Diagram🔀 Show diagramflowchart TD
A["Webhook receives review comment"] --> B{"/fix command?"}
B -->|yes| C["handleFixCommand(): auth, pause, write-access check"]
C --> D["FixTask dispatched to executor"]
D --> E["FixService.execute()"]
E --> F["Load finding body"]
F --> G["Load PR details & fork check"]
G --> H["Load file list & context contents"]
H --> I["Generate fix via AI (prompt)"]
I --> J{"Edits?"}
J -->|none| K["Reply decline with notes"]
J -->|exceed limit| L["Reply too broad"]
J -->|within limit| M["Apply edits (search/replace)"]
M -->|mismatch| N["Reply edit mismatch"]
M -->|success| O["Commit to bot branch via Git Data API"]
O --> P["Open fix PR targeting original PR's branch"]
P --> Q["Reply with PR link"]
Changes Overview
Changed Files
…and 5 more file(s). Risk Assessment
Things to double-check1 lower-confidence finding
|
| Check | Type | Status | Detail |
|---|---|---|---|
| format | missing | ⏳ Pending | - |
| test | missing | ⏳ Pending | - |
| frontend | missing | ⏳ Pending | - |
| trivy | missing | ⏳ Pending | - |
| dependency-review | missing | ⏳ Pending | - |
Automated review by ThrillhouseBot. Reply with /review to re-run.
There was a problem hiding this comment.
ThrillhouseBot noted 1 lower-confidence item(s) under Things to double-check in the PR summary (not posted as inline threads):
- MEDIUM: Fix context may miss files if the underlying file list lacks pagination (
src/main/java/dev/thiagogonzaga/thrillhousebot/review/FixService.java:140)
The /fix flow depends on the complete list of PR files (obtained via SoftLoaders.files). If that method does not implement pagination, only the first page (default 30 files on GitHub REST) will be provided, and files beyond that may be missing from the diff and context, leading to an incomplete fix. The project guidelines require listing calls to paginate. Verify that SoftLoaders.files fetches all files (e.g., walks pages until a short page), or document why one page is enough.
False positive ? The Feedback? Regarding the comments: the Softloaders line 86 calls As noted, the Softloaders line 86 calls This is by design: there is a |
Description
Related Issues
Closes: #57
How Has This Been Tested?
Checklist