test: cover the grounding guardrail branches - #16
Merged
Conversation
SonarCloud flagged uncovered conditions on the out-of-scope check in QueryService. Add unit tests for both sides (grounded answer keeps its sources; the fixed refusal suppresses them) plus a PromptBuilder assertion that the grounding instructions and context reach the prompt.
🤖 ThrillhouseBot PR SummaryWhat this PR doesAdds unit tests for the QueryService grounding guardrail, covering grounded answer (sources retained) and out-of-scope reply (sources suppressed), plus a PromptBuilder assertion that grounding instructions and context reach the prompt. Changes Overview
Changed Files
Risk Assessment
Everything's coming up Thrillhouse! 🎉 No issues found in this PR. Automated review by ThrillhouseBot. Reply with |
![thrillhousebot[bot]](https://avatars.githubusercontent.com/in/3996985?s=60&v=4){kind=small}
|
Owner
Author
|
@thrillhousebot, tem alguma breaking change nesse PR |
|
Não. O PR apenas adiciona um novo arquivo de teste ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15: SonarCloud flagged uncovered branch conditions on the out-of-scope check in
QueryService.Adds
QueryServiceGuardrailTest:PromptBuilderassertion that the grounding instructions and retrieved context reach the promptPure unit tests (Mockito, no Spring context). All 3 pass locally.