fix(workflows): remove obsolete containerImageName param from deploy step#63
Merged
Merged
Conversation
…step The ADO sync removed containerImageName from the Bicep templates, but the GitHub workflow still passed it, causing az deployment sub create to fail with exit code 1. Remove the variable and parameter to match the new Bicep contract; the container image is configured separately via ACR managed identity and docker push. Fixes #62
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing Deploy Azure Infrastructure job in
cicd.yml.After the ADO sync (commit d3e5ba1), the
containerImageNameparameter was removed from the Bicep templates (main.bicep,resources.bicep), but.github/workflows/cicd.ymlstill passed--parameters containerImageName=$containerImageName. Azure rejects deployments that supply undeclared parameters, soaz deployment sub createexited with code 1.Changes
$containerImageNamevariable.--parameters containerImageName=$containerImageNameline from the deploy step.The container image is configured separately via ACR managed identity + docker push, matching the new Bicep contract. The ADO pipeline was already correct — the GitHub workflow was the only side not updated during the sync.
Fixes #62