✨Integra método fetchActivityDetails na ActivityDetails e algumas refatorações#6
Open
r-fsantos wants to merge 7 commits into
Open
Conversation
r-fsantos
commented
Mar 10, 2023
r-fsantos
commented
Mar 10, 2023
| private extension ActivityDetailsViewController { | ||
|
|
||
| private func fetchDataView() { | ||
| service.fetchActivityDetails().subscribe(onSuccess: { [weak self ] activityDetails in |
Author
There was a problem hiding this comment.
Suggested change
| service.fetchActivityDetails().subscribe(onSuccess: { [weak self ] activityDetails in | |
| service.fetchActivityDetails().subscribe(onSuccess: { [weak self] activityDetails in |
Contributor
There was a problem hiding this comment.
Boa observação. Esse espaço extra, caso estivéssemos usando uma ferramenta de lint, provavelmente iria acusar um problema.
reisdev
suggested changes
Mar 13, 2023
Comment on lines
+14
to
+17
| protocol ActivityDetailsViewProtocol where Self: UIView { | ||
| var delegate: ActivityDetailsViewDelegate? { get set } | ||
| func show(viewModel: ActivityDetails) | ||
| } |
Contributor
There was a problem hiding this comment.
Nesse contexto, criar um protocolo para uma view não é muito usual. Manter as subviews como private é suficiente.
| private extension ActivityDetailsViewController { | ||
|
|
||
| private func fetchDataView() { | ||
| service.fetchActivityDetails().subscribe(onSuccess: { [weak self ] activityDetails in |
Contributor
There was a problem hiding this comment.
Boa observação. Esse espaço extra, caso estivéssemos usando uma ferramenta de lint, provavelmente iria acusar um problema.
reisdev
approved these changes
Mar 15, 2023
anacamargos
approved these changes
Mar 15, 2023
… and minors improvements - Creates a FinanceServiceEndpoints to improve readability - Inject dependencia via initializer to improve testability, as URLSession and JSONDecoder - Adds final to FinanceService class to improve performance by reducing DynamicDispatch
…ce and ActivityDetails)
… means of protocol conformance and Driver trait
r-fsantos
force-pushed
the
refactor/renato-fetch-activity-details
branch
from
f918054 to
d8a7fdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição simples da nova feature
fetchActivityDetailsnaActivityDetailsFinanceServiceFinanceService(sem aplicação do Princípio de Segregação de Interfaces)ActivityDetailsViewController(disposeBag,FinanceService,ActivityDetailsViewChecklist:
Coloque um
xnas caixas que se aplicam.