feat(cketh): TimedSizedMap bounded, time-expiring map by gregorydemay · Pull Request #10705 · dfinity/ic

gregorydemay · 2026-07-09T12:19:32Z

Adds a generic in-heap map bounded by both a hard entry cap and a per-entry time-to-live, which will be used to store addresses that needs to be watch over for deposits.

On insertion it first evicts entries that have outlived their TTL; it then rejects rather than evicts a live entry — returning AtCapacity if the map is full of live entries, or AlreadyPresent if the key already has a live entry (a caller cannot refresh/extend an entry by re-inserting it; re-admission is only possible once it has expired). Time is supplied by the caller (a Timestamp newtype), so the structure keeps no internal clock and is deterministic to test.
Modeled on the bounded cache in dfinity/canhttp (not a workspace dependency, hence a small local structure).

Copilot

Pull request overview

Introduces a new TimedSizedMap<K, V> utility in the ckETH minter crate: an in-heap, deterministic (caller-supplied time) map bounded by both a maximum entry count and a per-entry TTL, with eviction order of “expired first, then oldest”.

Changes:

Added TimedSizedMap + Timestamp newtype implementing TTL-based expiration and capacity eviction.
Added unit tests covering eviction/refresh/TTL edge cases and internal index consistency.
Exported the new module from lib.rs for reuse by later F3 state/endpoint wiring.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
rs/ethereum/cketh/minter/src/timed_sized_map.rs	New bounded, time-expiring map implementation (`TimedSizedMap`) with time index for eviction.
rs/ethereum/cketh/minter/src/timed_sized_map/tests.rs	Unit tests validating expiration, capacity eviction, refresh semantics, and index consistency.
rs/ethereum/cketh/minter/src/lib.rs	Exposes the new `timed_sized_map` module publicly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Add a generic in-heap map bounded by both a hard capacity and a per-entry time-to-live, evicting expired entries first and then the oldest to make room. Time is caller-supplied (Timestamp newtype) so the structure holds no clock and is deterministic to test. This is the standalone data structure that F3's per-account deposit-address registry will use to bound the active scanning set (DEFI-2921); wiring it into the minter state and the deposit_erc20 endpoint follows in later PRs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

remove_from_time_index is only called after an entry was removed from the primary map, so the timestamp bucket and the key must exist. Replace the silent no-op guards with expect("BUG: ...") so an inconsistent index fails loudly instead of drifting and panicking later in eviction. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…emantics - Remove the existing key before evicting expired entries, so re-inserting a key never reports its own previous value as an eviction (previously the behavior depended on whether that value had expired). - Replace the capacity loop's silent `break` with expect("BUG: ..."): an empty time index while entries is non-empty is an index-corruption bug, not a reason to insert past the hard capacity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

A still-armed deposit address must never be silently dropped from the watchlist: it may already have received funds. So TimedSizedMap::insert now evicts only expired entries and, if the map is still at capacity with only live entries, rejects a new key with an AtCapacity error rather than evicting a live one. Re-inserting an existing key still refreshes it (and is never rejected or reported as an eviction). Removes the now-unused evict_oldest. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Relocate the file-module src/timed_sized_map.rs to src/timed_sized_map/mod.rs, alongside its tests submodule. No code change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Removing an existing key already drops the map below capacity (len <= capacity is invariant), so the capacity check alone is sufficient; the separate refreshed flag never changed the outcome. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

… test - Expire an entry only once its age strictly exceeds `ttl` (now - inserted_at > ttl), so an entry lives for the full ttl. Replaces the inclusive saturating_add comparison with a checked duration. - Derive Clone/Eq/PartialEq on TimedSizedMap and assert the whole map is unchanged after a rejected insertion (clone-before, compare-after). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

A caller must not be able to refresh (extend) a still-live entry by re-inserting it, otherwise it could hold a slot indefinitely by repeatedly calling. insert now returns InsertError::AlreadyPresent for a live key; re-admission is only possible once the entry has expired. The error type becomes an enum (AlreadyPresent | AtCapacity), and the now-unused by-key remove helpers are dropped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

zeropath-ai · 2026-07-10T11:15:59Z

✅ No security or compliance issues detected. Reviewed everything up to f9e944d.

Security Overview

🔎 Scanned files: 3 changed file(s)
🔗 Scan Link: https://zeropath.com/app/repositories/783a9bd4-fb4e-4e10-ab3c-c2fb2ddfb92f?scanId=e02a1e31-d776-40ad-91ff-a798a5056a63&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type	Relevant files
Enhancement	► rs/ethereum/cketh/minter/src/lib.rs pub mod timed_sized_map;
Enhancement	► rs/ethereum/cketh/minter/src/timed_sized_map/mod.rs New module implementing TimedSizedMap with eviction and TTL logic
Enhancement	► rs/ethereum/cketh/minter/src/timed_sized_map/tests.rs Add tests for TimedSizedMap behavior and invariants

gregorydemay requested a review from Copilot July 9, 2026 12:19

github-actions Bot added the feat label Jul 9, 2026

Copilot started reviewing on behalf of gregorydemay July 9, 2026 12:20 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map.rs Outdated

gregorydemay requested a review from Copilot July 9, 2026 12:54

Copilot started reviewing on behalf of gregorydemay July 9, 2026 12:55 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map.rs Outdated

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map.rs Outdated

gregorydemay requested a review from Copilot July 9, 2026 13:26

Copilot started reviewing on behalf of gregorydemay July 9, 2026 13:28 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map.rs Outdated

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map/mod.rs

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map/mod.rs Outdated

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map.rs Outdated

Base automatically changed from ic_DEFI-2920_deposit-address-derivation to master July 9, 2026 16:06

gregorydemay and others added 3 commits July 10, 2026 08:36

gregorydemay force-pushed the ic_DEFI-2921_bounded-map branch from aaf656e to 4411504 Compare July 10, 2026 08:36

gregorydemay commented Jul 10, 2026

View reviewed changes

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map.rs Outdated

gregorydemay and others added 3 commits July 10, 2026 09:08

refactor(cketh): move timed_sized_map into a directory module

739a16e

Relocate the file-module src/timed_sized_map.rs to src/timed_sized_map/mod.rs, alongside its tests submodule. No code change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

gregorydemay commented Jul 10, 2026

View reviewed changes

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map/tests.rs Outdated

gregorydemay commented Jul 10, 2026

View reviewed changes

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map/mod.rs Outdated

gregorydemay commented Jul 10, 2026

View reviewed changes

Comment thread rs/ethereum/cketh/minter/src/timed_sized_map/tests.rs Outdated

gregorydemay marked this pull request as ready for review July 10, 2026 11:15

gregorydemay requested a review from a team as a code owner July 10, 2026 11:15

github-actions Bot added the @defi label Jul 10, 2026

gregorydemay mentioned this pull request Jul 10, 2026

feat(cketh): deposit_erc20 endpoint (derive + store deposit addresses) #10729

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(cketh): TimedSizedMap bounded, time-expiring map#10705

feat(cketh): TimedSizedMap bounded, time-expiring map#10705
gregorydemay wants to merge 8 commits into
masterfrom
ic_DEFI-2921_bounded-map

gregorydemay commented Jul 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeropath-ai Bot commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

gregorydemay commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeropath-ai Bot commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gregorydemay commented Jul 9, 2026 •

edited

Loading