Skip to content

feat(sns): Un-bless the Kong Swap SNS extension.#9667

Merged
daniel-wong-dfinity-org merged 3 commits intomasterfrom
un-bless-kong-swap-sns-extension-daniel-wong
Apr 7, 2026
Merged

feat(sns): Un-bless the Kong Swap SNS extension.#9667
daniel-wong-dfinity-org merged 3 commits intomasterfrom
un-bless-kong-swap-sns-extension-daniel-wong

Conversation

@daniel-wong-dfinity-org
Copy link
Copy Markdown
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Mar 30, 2026

@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner March 30, 2026 16:31
@github-actions github-actions bot added the feat label Mar 30, 2026
github-actions[bot]

This comment was marked as resolved.

@daniel-wong-dfinity-org daniel-wong-dfinity-org dismissed github-actions[bot]’s stale review March 30, 2026 16:36
  1. Done.
  2. This breaks people who want to create a Kong Swap extension, but we want them to break, because the alternative (extension gets creates, but Kong Swap no longer works) is worse.
  3. Existing data seems fine to me.
  4. If anything, we are locking things down more, so it seems very low risk.
@daniel-wong-dfinity-org daniel-wong-dfinity-org force-pushed the un-bless-kong-swap-sns-extension-daniel-wong branch from 53aca1d to 62ba99e Compare March 30, 2026 16:39
@daniel-wong-dfinity-org daniel-wong-dfinity-org added this pull request to the merge queue Apr 7, 2026
Merged via the queue into master with commit d257795 Apr 7, 2026
38 checks passed
@daniel-wong-dfinity-org daniel-wong-dfinity-org deleted the un-bless-kong-swap-sns-extension-daniel-wong branch April 7, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants