fix: extract manifest translation strings on start command#958
Merged
Conversation
|
dhis2-bot
added a commit
that referenced
this pull request
May 19, 2026
## [12.11.1](v12.11.0...v12.11.1) (2026-05-19) ### Bug Fixes * **i18n:** extract manifest translation strings on start command ([#958](#958)) ([0d7ac89](0d7ac89))
Contributor
|
🎉 This PR is included in version 12.11.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LIBS-828
Description
Previously, the start command would extract and generate all the translatable strings without the app title, description and shortcuts. This PR adds the
isApp flagjust as is done in thebuildcommand during i18n extraction of strings. This pulls the app title, description and shortcuts from dhis2.config.js and adds them to the translatable strings.