fix: [DHIS2-21544] Enrollment note: failed saves leave stale optimistic note in state#4577
Open
henrikmv wants to merge 1 commit into
Conversation
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DHIS2-21544
This PR adds error handling for when saving an enrollment note fails (A
DD_NOTE_FAILED_FOR_ENROLLMENT). Currently, notes are optimistically added to the UI, but if the server request fails, the note lingers with no indication of failure.The fix introduces two behaviours on failure:
New epic
removeNoteForEnrollmentEpiclistens for the failure action and dispatchesremoveEnrollmentNote, which the enrollment reducer handles by filtering out the failed note.