fix(headerbar): profile menu design changes#1670
Merged
Merged
Conversation
1a226d7 to
9f51f11
Compare
Contributor
|
Force-pushed this to rebase it onto the command palette branch, which will be ported to the global shell repo |
Contributor
|
🚀 Deployed on https://pr-1670--dhis2-ui.netlify.app |
|
KaiVandivier
approved these changes
Mar 3, 2025
Contributor
KaiVandivier
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @cooper-joe!
Changing the email props on these components is fine; the affected components aren't considered part of the external API 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Implements UX-113
Description
This PR updates the design of the profile menu in
HeaderBar. The following changes are made:buttoninstead ofMenuItemusernameinstead ofemailinProfileHeader.Questions:
emailprop from many components? I wasn't sure, as these components are not intended for consumption outside of the main profile menu component.Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots