feat(select): flexibility in dropdown menu width#1744
Open
arina-dhis2 wants to merge 1 commit into
Open
Conversation
|
Contributor
|
🚀 Deployed on https://pr-1744--dhis2-ui.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Implements LIBS-837
Description
SingleSelectandMultiSelectmeasure the input width and pass it to the dropdown as a fixed pixel width. That works for a wide input, but breaks when the input becomes too narrow: long labels get compressed in the menu, and the result looks unnecessarily tight.This PR adds two optional props —
menuMinWidthandmenuMaxWidth— onSingleSelect,MultiSelect,SingleSelectField, andMultiSelectField. They are forwarded through the sharedSelect/MenuWrapperstack.Known issues
With only
menuMinWidth(nomenuMaxWidth), the menu can grow without an upper bound for very long option labels;menuMinWidthandmenuMaxWidthshould be used together when labels can vary significantly in length.Checklist
Screenshots
menuMaxWidthis slightly greater than the width of the input, but less than the width of the options:with

menuMinWidth: