Skip to content

disable slack web hook (wrong params) #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-chaix-didomi merged 1 commit into from
Aug 19, 2026
Merged

disable slack web hook (wrong params) #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 23 additions & 22 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,28 +51,29 @@ jobs:
npm run prepare
npm publish --access public --provenance

notify:
name: Notify Slack
needs: build
# Release context is only available when triggered by a release (not workflow_dispatch)
if: github.event_name == 'release'
runs-on: ubuntu-latest
# Disable - wrong params - may use a mobile dedicated custom webhook
# notify:
# name: Notify Slack
# needs: build
# # Release context is only available when triggered by a release (not workflow_dispatch)
# if: github.event_name == 'release'
# runs-on: ubuntu-latest

steps:
- name: Send release announcement to Slack
env:
SLACK_WEBHOOK: ${{ secrets.RELEASES_SLACK_WEBHOOK }}
RELEASE_TAG: ${{ github.event.release.tag_name }}
RELEASE_BODY: ${{ github.event.release.body }}
RELEASE_URL: ${{ github.event.release.html_url }}
run: |
# Extract the changelog from the release body:
# drop the "More info" trailer and the leading "- " list markers.
# Trailing blank lines are stripped by the command substitution.
changelog=$(printf '%s\n' "$RELEASE_BODY" | tr -d '\r' | sed -e '/^More info:/,$d' -e 's/^- //')
# steps:
# - name: Send release announcement to Slack
# env:
# SLACK_WEBHOOK: ${{ secrets.RELEASES_SLACK_WEBHOOK }}
# RELEASE_TAG: ${{ github.event.release.tag_name }}
# RELEASE_BODY: ${{ github.event.release.body }}
# RELEASE_URL: ${{ github.event.release.html_url }}
# run: |
# # Extract the changelog from the release body:
# # drop the "More info" trailer and the leading "- " list markers.
# # Trailing blank lines are stripped by the command substitution.
# changelog=$(printf '%s\n' "$RELEASE_BODY" | tr -d '\r' | sed -e '/^More info:/,$d' -e 's/^- //')

text=$(printf '*React-Native SDK version `%s`* is now available :rocket:\n```%s```\nhttps://www.npmjs.com/package/@didomi/react-native/v/%s\n%s' \
"$RELEASE_TAG" "$changelog" "$RELEASE_TAG" "$RELEASE_URL")
# text=$(printf '*React-Native SDK version `%s`* is now available :rocket:\n```%s```\nhttps://www.npmjs.com/package/@didomi/react-native/v/%s\n%s' \
# "$RELEASE_TAG" "$changelog" "$RELEASE_TAG" "$RELEASE_URL")

jq -n --arg text "$text" '{ text: $text }' \
| curl --silent --show-error --fail -X POST -H 'Content-Type: application/json' -d @- "$SLACK_WEBHOOK"
# jq -n --arg text "$text" '{ text: $text }' \
# | curl --silent --show-error --fail -X POST -H 'Content-Type: application/json' -d @- "$SLACK_WEBHOOK"