fix: resolve issue #79 - Badge hover preview - link#121
Open
cryst6line wants to merge 1 commit intodiffplug:mainfrom
Open
fix: resolve issue #79 - Badge hover preview - link#121cryst6line wants to merge 1 commit intodiffplug:mainfrom
cryst6line wants to merge 1 commit intodiffplug:mainfrom
Conversation
Add a hover preview popup for link badges showing the link text/URL and social preview metadata (favicon, site name, title) Closes diffplug#79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a hover popup for link badges. When you hover over a link badge, you now see a preview that shows the link text, the URL, and some info about the site (like the favicon and page title if available). This makes it easier to see where a link actually goes before you click on it.
Why I made this change
Link badges are helpful for sharing resources, but without this preview you can't really tell what the link is without clicking it. Now users can see where they're headed before clicking.
What to look out for
The code review approved this, so it should be good to go. A couple things you might want to verify:
Testing
I ran the existing tests and they all passed.
Hi, I'm fairly new to open source and this is one of my earlier contributions — I hope I haven't missed anything obvious. Please don't hesitate to point out anything I've done wrong, I really appreciate the feedback.
Sorry if this isn't quite right — happy to make any changes you need!