Skip to content

feat: add DSL support#3

Merged
sbillinge merged 3 commits into
diffpy:mainfrom
ycexiao:add-dsl
Apr 3, 2026
Merged

feat: add DSL support#3
sbillinge merged 3 commits into
diffpy:mainfrom
ycexiao:add-dsl

Conversation

@ycexiao

@ycexiao ycexiao commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR address?

Add DSL(Domain Specific Langguage) support in diffpy.apps. It is migrated from PDF-bl/pdfbl.sequential#46, and details can be find in that PR.

What should the reviewer(s) do?

@codecov

codecov Bot commented Apr 2, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ycexiao ycexiao marked this pull request as ready for review April 2, 2026 16:36
@ycexiao

ycexiao commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge, it's ready for review.

@sbillinge sbillinge merged commit 606bcfc into diffpy:main Apr 3, 2026
6 checks passed
@sbillinge

Copy link
Copy Markdown
Contributor

fantastic! @ycexiao do we need docs for this now though?

@ycexiao

ycexiao commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge, Of course, we need give instructions about how to create the .dp-in file. I will create a issue and make a PR to it.

@ycexiao

ycexiao commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@sbillinge, this PR didn't create command entry point. My thought is:

diffpy.apps run --file <.dp-in>

Or as diffpy.apps refers to many applications, we can use something like:

diffpy-run(diffpy-exec) run <.dp-in>  

@sbillinge

Copy link
Copy Markdown
Contributor

Without giving it to much thought, yes. Diffpy.apps should support multiple apps that could have different names and run different functionality in general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants