chore: re-scikit-packaged diffpy.srmise#176
Merged
sbillinge merged 3 commits intodiffpy:mainfrom Apr 4, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 3 3
Lines 51 51
=======================================
Hits 39 39
Misses 12 12
🚀 New features to boost your workflow:
|
sbillinge
reviewed
Apr 4, 2026
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
please see the inline comment about copyright statements.
Also, please make sure that there is only one matrix and codecove workflow file (the new one) and if there is an old one with a different name that it is deleted.
Then I can merge
docs/source/license.rst
Outdated
| Copyright 2014-2015, Board of Trustees of Michigan State University | ||
|
|
||
| Copyright 2016-2025, The Trustees of Columbia University in the City of New York. | ||
| Copyright 2016-2026, The Trustees of Columbia University in the City of New York. |
Contributor
There was a problem hiding this comment.
please, everywhere, leave the original copyright statement, but add 2025-present diffpy.srmise contributors as an additional line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sbillinge ready to review. I have run the
package updateand recut the package. Note that there is no manual edit in the process. All the edits are done bypackage updateand I checked whether the edit is needed/appropriate.