#218 use buildx to build for both amd64 and arm64.#221
Open
gaslitbytech wants to merge 2 commits intodjrobstep:masterfrom
Open
#218 use buildx to build for both amd64 and arm64.#221gaslitbytech wants to merge 2 commits intodjrobstep:masterfrom
gaslitbytech wants to merge 2 commits intodjrobstep:masterfrom
Conversation
gaslitbytech
changed the title
…ing my docker account montage
Author
|
Tested this using my docker account. I added a few lines that may save branches / tests being pushed to latest accidentally. Images are temporarily pushed to dockerhub and will I'll remove once you have a chance to see that it works. https://hub.docker.com/r/montage/migra/tags Edit: wrong URL |
|
@djrobstep could we get this PR merged? it would solve the an issue where this image will fail if containerd is enabled in Docker desktop on an M1 chip. supabase/cli#1027 |
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this small change will help enable multi platform docker images to be pushed to dockerhub.
buildx is now installed on Docker for Mac + Docker for Windows by default
If this helps the process of publishing to dockerhub it will close #218
This has been tested on MacOS with intel (amd64) architecture.