Skip to content

Dockerfile: update golangci-lint to v2.10.1#6826

Merged
thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah:bump_golangci_lint2
Apr 20, 2026
Merged

Dockerfile: update golangci-lint to v2.10.1#6826
thaJeztah merged 2 commits intodocker:masterfrom
thaJeztah:bump_golangci_lint2

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah modified the milestones: 29.3.0, 29.3.1 Mar 4, 2026
@vvoland
Copy link
Copy Markdown
Collaborator

vvoland commented Apr 1, 2026

Need to fix the linter failures

@thaJeztah
Copy link
Copy Markdown
Member Author

yup; saw those, and decided to leave it for a later exercise 😆

@thaJeztah thaJeztah modified the milestones: 29.4.0, 29.4.1 Apr 3, 2026
@thaJeztah thaJeztah modified the milestones: 29.4.1, 29.4.2 Apr 20, 2026
@vvoland
Copy link
Copy Markdown
Collaborator

vvoland commented Apr 20, 2026

I went ahead and pushed a commit to unblock the CI.

Copy link
Copy Markdown
Member Author

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah modified the milestones: 29.4.2, 29.4.1 Apr 20, 2026
@thaJeztah
Copy link
Copy Markdown
Member Author

LOL; can't approve it myself; and maybe you won't be able to either because you last pushed, but can you give it a try @vvoland ?

@vvoland
Copy link
Copy Markdown
Collaborator

vvoland commented Apr 20, 2026

Heh, I can approve, but not merge 😅

@thaJeztah
Copy link
Copy Markdown
Member Author

Let me try if I push again.

thaJeztah and others added 2 commits April 20, 2026 15:49
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@thaJeztah thaJeztah force-pushed the bump_golangci_lint2 branch from fa71325 to 58a7c31 Compare April 20, 2026 13:49
@thaJeztah
Copy link
Copy Markdown
Member Author

can you try approving again? 😂 🫠

@vvoland
Copy link
Copy Markdown
Collaborator

vvoland commented Apr 20, 2026

image

@vvoland
Copy link
Copy Markdown
Collaborator

vvoland commented Apr 20, 2026

Feel free to squash and reset the commit author so it doesn't see me 😅

@thaJeztah
Copy link
Copy Markdown
Member Author

But they were not; I pushed! 😂

@thaJeztah
Copy link
Copy Markdown
Member Author

Thanks Rob!

@thaJeztah thaJeztah merged commit 134c2a0 into docker:master Apr 20, 2026
108 of 109 checks passed
@thaJeztah thaJeztah deleted the bump_golangci_lint2 branch April 20, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants