feat: automatically add socket's group when using --use-api-socket#6993
Open
felipecrs wants to merge 1 commit into
Open
feat: automatically add socket's group when using --use-api-socket#6993felipecrs wants to merge 1 commit into
--use-api-socket#6993felipecrs wants to merge 1 commit into
Conversation
09270dc to
232d4bd
Compare
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
232d4bd to
6b4bef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
The
--use-api-socketflag is great, but it didn't account for the case when the container is executed as a non-root user that is not part of the socket's group:This PR makes it so that
--use-api-socketwill account for this case.- How I did it
This PR improves the
--use-api-socketflag so that it automatically discovers the socket's group and adds it, equivalent to manually passing--group-add $(stat -c '%g' /var/run/docker.sock).- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)