Dockerfile: update golang image to alpine 3.23#13921
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Dockerfile build base image to a supported Alpine variant after the alpine3.22 tag was removed, keeping the build pipeline functional.
Changes:
- Switch the Go build stage base image from
golang:${GO_VERSION}-alpine3.22togolang:${GO_VERSION}-alpine3.23.
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Reviewed the single-line change updating the Go builder base image from golang:${GO_VERSION}-alpine3.22 to golang:${GO_VERSION}-alpine3.23.
No issues found. This is a clean, necessary version bump — Alpine 3.22 has been removed upstream, so switching to Alpine 3.23 is the correct fix. The change is minimal, well-scoped, and consistent with the project's recent history of keeping the builder image up to date.
|
Hm... more changes needed |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The alpine 3.22 variant was removed.
Also updating the macOS SDK version to avoid errors when building
on alpine 3.23;
1.107 GO111MODULE=on go build -trimpath -tags "fsnotify,e2e" -ldflags "-w -X github.com/docker/compose/v5/internal.Version=61203c8" -o "/out/docker-compose" ./cmd
37.96 # runtime/cgo
37.96 clang: error: overriding deployment version from '10.16' to '11.0' [-Werror,-Woverriding-deployment-version]
39.77 make: *** [Makefile:61: build] Error 1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
| ARG BUILD_TAGS | ||
| ARG BUILD_FLAGS | ||
| ARG TARGETPLATFORM | ||
| ARG MACOSX_VERSION_MIN=11.0 |
There was a problem hiding this comment.
This should probably do the trick
The alpine 3.22 variant was removed.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did