fix(watch): stop pruning every dangling image of the project - #14012
Open
glours wants to merge 1 commit into
Open
fix(watch): stop pruning every dangling image of the project#14012glours wants to merge 1 commit into
glours wants to merge 1 commit into
Conversation
pruneDanglingImagesOnRebuild probed the name-keyed built-images map with an image ID, so the spare-check never matched and every dangling image carrying the project label was removed on each rebuild with --prune — not just the superseded ones. Match dangling IDs against the map's values (the freshly built image IDs) instead. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
pruneDanglingImagesOnRebuild probed the name-keyed built-images map with an image ID, so the spare-check never matched and every dangling image carrying the project label was removed on each rebuild with --prune — not just the superseded ones. Match dangling IDs against the map's values (the freshly built image IDs) instead.
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation to what you did
