fix(compose): resolve multiple epic #14074 findings - #14116
Open
madhoshyagnik wants to merge 1 commit into
Open
Conversation
- Fix bug where success boolean in bus.Done was inverted in pkg/compose/progress.go - Move Watcher mutex from package-level to struct-level in pkg/compose/watch.go - Fix state machine leak in Watcher.Start on failed start - Add AI_AGENT_DISCLOSURE.md Ref docker#14074 Signed-off-by: madhoshyagnik <madhosh1yagnik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs identified in #14074:
successboolean inbus.Donewas inverted inpkg/compose/progress.goWatchermutex from package-level to struct-level inpkg/compose/watch.goWatcher.Starton failed startRef #14074