docs: explain org-member review flow for external contributor PRs#18
Open
Sayt-0 wants to merge 1 commit into
Open
docs: explain org-member review flow for external contributor PRs#18Sayt-0 wants to merge 1 commit into
Sayt-0 wants to merge 1 commit into
Conversation
Document the UX for org members handling external and fork contributor PRs: approve the workflow run, then request a review from docker-agent via GitHub's native review-request UI. No special commands or workflow inputs are needed. Additive only (new sections), kept out of the regions PRs #16 and #13 edit, so it merges cleanly against both. Aligns with PR #16's requester-authorized model, which is what enables review of external contributor PRs; that behavior requires PR #16 to land first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Merge #16 first. This PR documents the requester-authorized review flow for external and fork contributor PRs, which only works once #16 (
feat(review-pr): authorize review_requested via the requester for external contributors) lands. Merging this ahead of #16 would describe a flow that does not yet function and would briefly contradict the on-main defense-in-depth text that #16 updates.Summary
Documents the UX for org members handling external and fork contributor PRs across three docs. The flow, with no special commands or workflow inputs:
docker-agentvia the native review-request UI (PR sidebar, Reviewers).review-pr/README.mdExternal and fork contributor PRssection with the full two-step flowCONTRIBUTING.mdAutomated PR Reviewsection (org members vs external and fork contributors)README.mdAlignment with open PRs
Conflict avoidance
Changes are additive. The new section in
review-pr/README.mdis inserted beforeCustomizing, outside the regions #16 and #13 edit (the "What you get" trigger table and the defense-in-depth blockquote), so it merges cleanly against both.Validation
#external-and-fork-contributor-prs)