Fix type of RFAdjointMat vector, and fix typo in RFMat.multHermitian#252
Open
JHopeCollins wants to merge 3 commits into
Open
Fix type of RFAdjointMat vector, and fix typo in RFMat.multHermitian#252JHopeCollins wants to merge 3 commits into
JHopeCollins wants to merge 3 commits into
Conversation
jrmaddison
requested changes
Apr 6, 2026
JHopeCollins
requested review from
jrmaddison
and removed request for
jrmaddison
jrmaddison
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key change is on line 358: the adjoint mat should act on the dual type to the functional.
The changes on lines 243-249 are just switching the names of x and y in
multHermitianbecause I think it is easier to read that way:Ax=yformultandA^{T}y = xformultHermitian.