Truncate long block labels#254
Open
connorjward wants to merge 1 commit into
Open
Conversation
JHopeCollins
requested changes
Apr 17, 2026
Contributor
There was a problem hiding this comment.
This is really useful, thanks! Please can we also allow passing the width through:
Tape.visualise->Tape.visualise_*->Tape.create_graph->Block.create_graph
so it can be set by the user (with the default value you already have)?
Arguably Tape.visualise should call Tape.create_graph directly and pass the graph to each of the visualise_* methods, which would slightly simplify passing through arguments, but that's just style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the tape much much more readable for cases where the
__str__of a block is too large. Since this code path is only touched during visualisation I argue that losing information here is fine.