feat: add right-click activation for tiling system with Wayland support#509
Open
tho-maj wants to merge 2 commits intodomferr:mainfrom
Open
feat: add right-click activation for tiling system with Wayland support#509tho-maj wants to merge 2 commits intodomferr:mainfrom
tho-maj wants to merge 2 commits intodomferr:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the option to activate the tiling layout by holding the Right Mouse Button while dragging a window. This has been integrated as a new option in the "Activation Key" settings.
Implementation Details & Wayland Support
Implementing this for Wayland was challenging due to Mutter's grab behavior. This PR includes a robust solution for the following issues:
grab-op._isRMBInterrupted). When the official grab is interrupted, the window now continues to follow the cursor manually using stored offsets until the Left Mouse Button is released._isManualSnapto ensure the tiling logic correctly finalizes the snap even after the official grab state has ended.BUTTON2_MASKandBUTTON3_MASKto account for environment-specific mapping variations during window moves.user_op: trueduring the final snap to guarantee the correctly adopt the tile dimensions.Testing