feat: add Gnome 50 support#535
Open
bendavis78 wants to merge 1 commit into
Open
Conversation
|
What does this PR add that is not already in https://github.com/domferr/tilingshell/commits/v18.0/ ? |
|
brooo, i love you!!! |
The Hence everything is in v18 already. Nevermind. I just had to update via https://extensions.gnome.org/extension/7065/tiling-shell/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNOME 50 support
Adds GNOME 50 to the supported shell versions and fixes Super key detection, which silently broke in GNOME 50 due to a modifier mask change.
esbuild bump to ^0.28.0
esbuild-sass-plugin@3.7.0requiresesbuild >= 0.27.3as a peer dep. The previous^0.25.10pin causednpm installto fail with a dependency resolution error.Super key modifier detection
global.get_pointer()returns XKB-serialized modifiers where Super is reported asMOD4_MASK(bit 6), notSUPER_MASK(bit 26).SUPER_MASKis a virtual modifier absent from the XKB state returned byxkb_state_serialize_mods(), so any feature that checks for Super (e.g. Super+drag to tile) was a silent no-op on GNOME 50.Alt was already handled correctly via
MOD1_MASK; this brings Super in line with the same approach. Also consistent with Mutter commit c0fd2d9556 ("core: Let key presses of special modifiers through"), which changed overlay key handling to propagate the initial Super press rather than consume it.Closes #531