Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
name: code-review
description: Guidelines for conducting code reviews on pull requests.
---

# Code Review Skill

## Overview
Perform thorough, constructive code reviews focusing on security, code quality, testing, and standard architecture practices.

## Guidelines

### 1. Security & Authentication
- Verify that endpoints requiring authentication use appropriate guards/middleware.
- Ensure sensitive configurations load via environment variables rather than hardcoded strings.
- Validate incoming payload schemas to prevent injection vulnerabilities.

### 2. Code Quality & Architecture
- Ensure type annotations are fully defined across function signatures.
- Keep controller/handler logic thin by delegating business logic to service layers.
- Check for redundant logic or missed modularization opportunities.

### 3. Testing
- Confirm new features or bug fixes include corresponding unit or integration tests.
- Verify test suites pass without regressions.

## Review Output Format
Structure review feedback as follows:
- **Summary**: Concise high-level overview.
- **Critical/Blocking**: Security risks, bugs, or breaking changes.
- **Suggestions**: Non-blocking improvements or refactoring advice.
- **Positives**: Notable well-implemented design decisions.