feat(#34972): Nestable Hosts — allow hosts to have parent hosts/folders for path-based URL hierarchies#34973
Draft
feat(#34972): Nestable Hosts — allow hosts to have parent hosts/folders for path-based URL hierarchies#34973
Conversation
…rs for path-based URL hierarchies Implements the full nestable-hosts feature: ## Data Model - No new DB columns; reuses Identifier.host_inode, parent_path, asset_name - Identifier.asset_name = hostname for all host records (synced by startup task) - Top-level hosts anchor to SYSTEM_HOST; nested hosts anchor to parent host/folder ## URL Resolution - NestedHostResolutionFilter intercepts requests and resolves nested hosts - NestedHostPatternCache: per-top-level-host regex cache, longest-first matching, PostgreSQL LISTEN/NOTIFY invalidation - CMS_RESOLVED_HOST request attribute set; HostWebAPIImpl checks it first - HostResolver: (serverName, fullUri) → HostResolutionResult ## Host Lifecycle - Deleting host with descendants blocked (HostHasDescendantsException) - Cascade archive to all descendants; unarchive is manual - Reparent fires HostReparentPayload (oldTopLevelHostId, newTopLevelHostId) - Cycle detection in IdentifierAPI.getTopLevelHostId() ## Push Publishing - Auto-includes ancestor hosts in push bundles - Import sorts HOST+FOLDER records by path length ascending ## Angular UI - Site selector shows flat list with depth-based indentation (DotHostDepthPipe) - Folder tree shows nested host nodes with host icon; click switches context - BrowserResource/ContentDriveResource support showSubHosts param - Content editor accepts ?hostId= for HostFolderField pre-fill - Modern syntax: @if, input(), signals throughout ## Startup Tasks - Task260312: adds parentHost HostFolderField to Host content type - Task260313: syncs Identifier.asset_name = hostname for all host records ## Tests - 140 unit tests pass - 47 HostAPITest integration tests pass (including 3 new nestable-host tests) - 10/10 HostFactoryImplTest pass - 2/2 Task260312 integration tests pass - 4/4 Task260313 integration tests pass - MainSuite3a updated to include new startup task tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
27 tasks
github-actions
bot
added
Area : Backend
…ements - Fix Jackson @JsonProperty("isHost") on FolderSearchResultView and FolderView so nested-host nodes render their label correctly in the Content Drive folder tree - Fix ShortyIdAPIImpl.getShorty(null) NPE when legacy browser clicks nested-host node - Fix HostAPIImpl: capture hostname before checkin() so identifier.asset_name is set correctly for new sub-hosts (same pre/post-checkin pattern as parentHostId fix) - Design change: nested-host nodes in Content Drive open like folders instead of switching the global site context; add browseHostname state field to track browsed host independently of currentSite - Fix includeSystemHost: only true at top-level site root (!browseHostname && !path) to prevent SYSTEM_HOST content bleeding into nested-host/folder views - Add BrowserAjax.getChildHostMaps() to show direct child hosts in legacy folder tree - Fix BrowserAjax.openFolderTree() to resolve host inodes via IdentifierAPI so clicking a sub-host node in the legacy browser expands its folder tree correctly - Update docs/nestable-hosts-requirements.md to reflect folder-like behavior (AC-17) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34972
Summary
Identifier.host_inode,parent_path,asset_namewith extended semantics; top-level hosts anchor toSYSTEM_HOST, nested hosts anchor to parent host/folderNestedHostResolutionFilterintercepts requests, resolves nested host viaNestedHostPatternCache(per-top-level-host regex, longest-first, PostgreSQL LISTEN/NOTIFY invalidation), strips host prefix from URI, setsCMS_RESOLVED_HOSTon requestHostResolverservice:(serverName, fullUri) → HostResolutionResultcascade=true); unarchive is manual; cycle detection throws before any data is persisted; reparent firesHostReparentPayloadDotHostDepthPipe), folder tree nested host nodes,showSubHostsparam in Browser/ContentDrive APIs,?hostId=query param for HostFolderField pre-fill; modern syntax (@if,input(), signals)Task260312addsparentHostHostFolderField to Host content type;Task260313syncsIdentifier.asset_name = hostnameTest plan
HostAPITest: 47/47 integration tests pass (includes 3 new nestable-host tests)HostFactoryImplTest: 10/10Task260312AddHostFolderFieldToHostContentTypeTest: 2/2Task260313SyncHostIdentifierAssetNameTest: 4/4MainSuite3aupdated with new startup task tests🤖 Generated with Claude Code