Respect workflow resolution for scheduled publishing#36594
Open
riccardoruocco wants to merge 1 commit into
Open
Respect workflow resolution for scheduled publishing#36594riccardoruocco wants to merge 1 commit into
riccardoruocco wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0860e845f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Make the scheduled publishing workflow gate optionally scheme-selective and ensure failed workflow lookups still close the batch transaction.
riccardoruocco
force-pushed
the
fix/publish-date-workflow-resolution
branch
from
July 16, 2026 11:28
0860e84 to
d60c7a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
PUBLISH_JOB_QUEUE_RESPECT_WORKFLOW_RESOLUTIONconfiguration flag, disabled by default.PublishDateUpdaterfrom locally publishing scheduled content unless its current workflow step is resolved.PUBLISH_JOB_QUEUE_RESPECT_WORKFLOW_RESOLUTION_SCHEMESto optionally scope the check to comma-separated workflow scheme IDs or variable names.Checklist
Additional Info
This change only affects local publishing triggered by
PublishDateUpdaterwhen a scheduledpublishDatematures.The main flag defaults to
false, preserving the existing dotCMS behavior. When enabled with an empty workflow list, scheduled publishing is allowed only when the content's current workflow step hasresolved=true. When workflow scheme IDs or variable names are configured, the gate applies only to those workflows.For content without a current step, the global mode keeps the conservative behavior and blocks scheduled publication. In scoped mode, it blocks only when the content type is assigned to one of the configured workflow schemes.
Immediate workflow publishing and push publishing are not intercepted by this check. Scheduled expiration/unpublishing is also unaffected.
Workflow lookup failures are handled conservatively: the affected content item is not published, processing continues for the remaining items, and the batch transaction is still closed.
Validation performed:
PublishDateUpdaterTest: 11 tests passed.main.git diff --checkpassed.Screenshots
Not applicable — backend-only change with no UI modifications.