Documentation | Correct SqlDataRecord, SqlMetaData documentation#4440
Open
edwardneal wants to merge 2 commits into
Open
Documentation | Correct SqlDataRecord, SqlMetaData documentation#4440edwardneal wants to merge 2 commits into
edwardneal wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The existing documentation for both types is located here:
SqlDataRecordSqlMetaDataThese pages are incorrect - they refer to the
SqlContextand theSqlPipetypes, which have never existed. There's also an open issue which asks for more information on whether it's valid for users to reuseSqlDataRecordinstances.This PR corrects the documentation for these two types, addressing #1805 in the process.
It might also be worthwhile backporting this to the other release branches, this is just documenting their existing behaviour.
Issues
Fixes #1805.
Testing
This isn't a functional change - just a change to documentation.