Remove legacy machine.config resource - #12317
Open
jonathanpeppers wants to merge 1 commit into
Open
Conversation
Stop copying the unused legacy configuration file into Android intermediate assets and remove the embedded resource. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0742e7ec-25d9-467b-90ea-6d1f78ac30fe
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a legacy machine.config embedded resource that was still being copied into Android intermediate assets, aligning modern .NET Android builds with current runtime expectations and addressing #7350.
Changes:
- Stop copying
machine.configinto$(MonoAndroidIntermediateAssemblyDir)during the static resources step. - Remove
machine.configfrom@(FileWrites)so it’s no longer tracked as a build output. - Update the
CopyResourceembedded resource test list and delete the unused resource file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets | Removes the CopyResource invocation and FileWrites entry for machine.config. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/CopyResourceTests.cs | Updates the embedded-resource presence test to no longer expect machine.config. |
| src/Xamarin.Android.Build.Tasks/Resources/machine.config | Deletes the unused legacy embedded resource. |
jonathanpeppers
added
the
ready-to-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
machine.configfile into Android intermediate assetsFixes #7350
Testing
Xamarin.Android.Common.targetsas XMLmaintargets .NET 11