Unquarantine AddValidationIntegrationTest.FormWithNestedValidation_Works - #68280
Open
oroztocil wants to merge 1 commit into
Open
Unquarantine AddValidationIntegrationTest.FormWithNestedValidation_Works#68280oroztocil wants to merge 1 commit into
oroztocil wants to merge 1 commit into
Conversation
Reverts c10ee0e (#68224). The quarantine was based on stale CI data. All four builds cited in #68223 (1499278, 1499615, 1499768, 1500081) ran on 2026-07-08, before the fix in #67680 landed. The test has not failed on main since. Closes #68223 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 27921814-71c2-4b25-a2e5-54a637a17759
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request unquarantines AddValidationIntegrationTest.FormWithNestedValidation_Works by removing the quarantine attribute that was added based on stale CI failure data, restoring the test to the normal (non-quarantined) test run.
Changes:
- Removed the
[QuarantinedTest(...)]attribute fromFormWithNestedValidation_Works. - Removed the now-unused
Microsoft.AspNetCore.InternalTestingusing directive.
Member
Author
|
Let's merge this on Monday so we avoid the bot spawning the issue again. Last failure will be > 30 days ago on Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts c10ee0e (#68224), which quarantined
AddValidationIntegrationTest.FormWithNestedValidation_Works.The quarantine was based on stale CI data. The test is not flaky and MEV activation is not broken.
The cited failures are all from before the fix
Issue #68223 lists four failing builds. All of them ran on 2026-07-08, and none of them contain the fix commit
0c3e825607(#67680), which merged on 2026-07-08 at 19:48 UTC.3e156e1a74(#67636, the regression itself)12fe5679d84b9040ecc8cb1ac26bbdThese are the same builds already tracked by #67699, which was closed once #67680 merged. Issue #68223 effectively re-filed an already resolved problem a month later.
For contrast, the sibling issue #68226, generated by the same
Daily Test Quarantine Managementworkflow run, cites genuinely recent builds (1531284, 1537634). So only this one issue picked up stale data.The original failure was deterministic, not a race
Both #67699 and #68223 describe the failure as a timing or rendering race. It was not.
PR #67636 removed generator discovery of
Microsoft.Extensions.Validation.Embedded.ValidatableTypeAttributefromValidationsGenerator. The test modelOrderModelwas annotated with an unqualified[ValidatableType]that bound to that SDK embedded attribute, so after #67636 the generator stopped emitting validatable type info for it.Without a source generated resolver,
DataAnnotationsValidatorfell back to the plainSystem.ComponentModel.DataAnnotations.Validatorpath, which does not recurse into nested complex properties. That produces exactly the observed result: only the top levelOrder Name is required.message, and nothing fromCustomerModel,AddressModel, orOrderItemModel.PR #67680 fixed it by fully qualifying the attribute to
[Microsoft.Extensions.Validation.ValidatableType]. That annotation is still in place today (src/Components/test/testassets/Components.TestServer/RazorComponents/ValidationModels/OrderModel.cs), andValidationsGenerator.csstill discoversMicrosoft.Extensions.Validation.ValidatableTypeAttribute.Separately, #67702 added
src/Validation/*to theaspnetcore-components-e2epath triggers, so MEV changes now run these E2E tests on the PR.The test has been green since
Across all 127
aspnetcore-components-e2ebuilds onmainbetween 2026-07-09 and the quarantine on 2026-08-05,FormWithNestedValidationdoes not appear in any build log. The test name is only emitted on failure, so zero occurrences means zero failures.The 17 builds that failed in that window failed for unrelated reasons: Mono leg failures, 120 minute agent timeouts, and other already quarantined tests.
Spot checks immediately before the quarantine:
Run E2E testspassed, only quarantined legs failedRun E2E testspassed, only quarantined legs failedRun E2E testspassed, only quarantined legs failedAnd after the quarantine landed, 1541387 (2026-08-05 18:07, includes
c10ee0eb58) ran the test in the quarantined leg and it passed there too.Change
Removes the
[QuarantinedTest]attribute and the now unusedMicrosoft.AspNetCore.InternalTestingusing directive.Closes #68223