Prevent SOS CLR notification failures from wedging cdb - #5965
Draft
hoyosjs wants to merge 2 commits into
Draft
Conversation
Resume live targets when CLR notification handling cannot initialize and preserve primary DAC load failures. Add deterministic cdb regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Isolate SOS without its bundled cDAC so the regression exercises the notification-handler failure path consistently across local and CI layouts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3fff557b-adf1-4873-94d6-676153db5c5e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues addressed
Prevents
!bpmdCLR-notification callbacks from leaving the target parked atKERNELBASE!RaiseException, which causes later SOS commands to report missing runtime or DAC failures.Breaking changes
None.
Manual validation
Ran the live cdb fault repro with four consecutive CLR-notification handler failures and verified it reached the deliberate
DebugBreak. Repeated the default-CI-environment scenario 10 times.