Skip to content

Fix paths in Dev Containers.#38614

Merged
cincuranet merged 1 commit into
dotnet:mainfrom
cincuranet:devcontainer-fix
Jul 13, 2026
Merged

Fix paths in Dev Containers.#38614
cincuranet merged 1 commit into
dotnet:mainfrom
cincuranet:devcontainer-fix

Conversation

@cincuranet

Copy link
Copy Markdown
Contributor

Fixes #36426

Copilot AI review requested due to automatic review settings July 13, 2026 08:22
@cincuranet cincuranet requested a review from a team as a code owner July 13, 2026 08:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the EF Core Dev Container configuration so the workspace mount and related paths match the actual container workspace folder, preventing failures like attempting to run /efcore/efcore/restore.sh during container creation (per #36426).

Changes:

  • Updates the Docker Compose volume mount to use /workspaces/efcore.
  • Aligns devcontainer.json’s workspaceFolder, dotnet.dotnetPath, PATH, and onCreateCommand to use ${containerWorkspaceFolder} without the erroneous /efcore segment.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.devcontainer/docker-compose.yml Mounts the repo into /workspaces/efcore to match Dev Container conventions and the configured workspace folder.
.devcontainer/devcontainer.json Fixes workspace and tool/script paths to resolve correctly under ${containerWorkspaceFolder}.

@cincuranet cincuranet merged commit 34560b1 into dotnet:main Jul 13, 2026
16 checks passed
@cincuranet cincuranet deleted the devcontainer-fix branch July 13, 2026 18:17
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

devcontainer.json has incorrect file paths

3 participants