Add netstandard2.0 and net462 TFM support to AmbientMetadata.Build#7463
Open
aykutkaann wants to merge 1 commit intodotnet:mainfrom
Open
Add netstandard2.0 and net462 TFM support to AmbientMetadata.Build#7463aykutkaann wants to merge 1 commit intodotnet:mainfrom
aykutkaann wants to merge 1 commit intodotnet:mainfrom
Conversation
github-actions
bot
added
the
area-ai-eval
Author
|
CI failures appear to be unrelated to my change — they are in Microsoft.Extensions.ServiceDiscovery.Dns.Resolver.Tests.TcpFailoverTests, which is a different package from AmbientMetadata.Build. These look like pre-existing flaky tests related to socket/network behavior in the CI environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7415
Summary
Added
netstandard2.0andnet462target frameworks toMicrosoft.Extensions.AmbientMetadata.Buildpackage to match theMicrosoft.Extensions.AmbientMetadata.Applicationpackage, which already supports these TFMs.Changes
TargetFrameworksinMicrosoft.Extensions.AmbientMetadata.Build.csprojfrom$(NetCoreTargetFrameworks)to$(NetCoreTargetFrameworks);netstandard2.0;net462Context
The
Applicationpackage already targetsnetstandard2.0andnet462, but theBuildpackage did not, preventing usage in projects targeting these frameworks. As noted in the issue, there is no specific code preventing this package from working on these platforms.Microsoft Reviewers: Open in CodeFlow