[msbuild] Reword the message about using DEVELOPER_DIR or XcodeLocation to choose Xcode. - #26420
[msbuild] Reword the message about using DEVELOPER_DIR or XcodeLocation to choose Xcode.#26420rolfbjarne wants to merge 2 commits into
Conversation
…on to choose Xcode. Trying to clarify that it's not necessary to set these variables, we'll use the system's default Xcode if neither are specified.
There was a problem hiding this comment.
Pull request overview
This PR updates the MSBuild warning text shown when legacy Xcode-selection mechanisms are detected (deprecated MD_APPLE_SDK_ROOT and deprecated settings plist files), clarifying that users only need to set DEVELOPER_DIR/XcodeLocation when they want to override the system-default Xcode.
Changes:
- Reworded W7171–W7174 localized warning strings to better explain default-Xcode behavior.
- Updated corresponding unit test warning filters to match the revised message text.
- Updated inline comments in
DetectSdkLocationto reflect the new wording.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/dotnet/UnitTests/Extensions.cs | Updates warning-filter string/regex matches to align with the new warning wording. |
| msbuild/Xamarin.MacDev.Tasks/Tasks/DetectSdkLocation.cs | Updates inline comment text for the warnings emitted when deprecated Xcode-selection mechanisms are found. |
| msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx | Rewords localized warning messages W7171–W7174 to clarify Xcode default/override behavior. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build #1ef5a92] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 205 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Trying to clarify that it's not necessary to set these variables, we'll use the system's default Xcode if neither are specified.