migrate ResolveStaticWebAssetsEmbeddedProjectConfiguration#54885
Merged
AlesProkop merged 1 commit intoJun 22, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR marks ResolveStaticWebAssetsEmbeddedProjectConfiguration as safe to run under MSBuild’s multithreaded task scheduler by adding the [MSBuildMultiThreadableTask] attribute, aligning it with other metadata-only Static Web Assets tasks.
Changes:
- Added
[MSBuildMultiThreadableTask]toResolveStaticWebAssetsEmbeddedProjectConfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/msbuild#14062
Context
ResolveStaticWebAssetsEmbeddedProjectConfigurationcan run under MSBuild's multithreaded task scheduler because it only transforms task item metadata in memory and does not use file I/O, environment state, process state, or current-directory-dependent APIs.Changes Made
[MSBuildMultiThreadableTask]toResolveStaticWebAssetsEmbeddedProjectConfiguration.Testing
src/StaticWebAssetsSdk/Tasks/Microsoft.NET.Sdk.StaticWebAssets.Tasks.csproj— succeeded.